fix(android): pass --scale with 4-decimal precision - #343
Conversation
%.2f quantized the requested capture scale (0.4988 became "0.50"), making fine-grained scale adjustments a no-op on the device encoder.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthrough
ChangesScreen capture configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change preserves fine-grained Android capture scale values, and no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
%.2f quantized the requested capture scale before it reached devicekit — 0.4988 became "0.50", so fine-grained scale adjustments were silently a no-op (found while diagnosing the odd-dimension capture failure, mobile-next/devicekit-android#42). %.4f keeps the requested value.
Summary by CodeRabbit