feat: optional duration for swipe gestures - #344
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (9)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe CLI and server now accept swipe durations. Commands and device interfaces propagate the value. Android uses a 1000 ms default for non-positive values, while DeviceKit and remote implementations send positive durations only. ChangesSwipe duration propagation
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🔵 Low · up to The swipe duration option is mergeable, but iOS users connected to agents older than devicekit-ios 0.0.24 may have the duration ignored or the request rejected, so the compatible agent version should be confirmed. Sequence Diagram(s)sequenceDiagram
participant CLI
participant Server
participant SwipeCommand
participant Device
participant DeviceKitClient
CLI->>SwipeCommand: Submit swipe with --duration
Server->>SwipeCommand: Submit JSON duration
SwipeCommand->>Device: Pass coordinates and duration
Device->>DeviceKitClient: Forward positive duration when applicable
Device-->>SwipeCommand: Complete swipe
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2cbf7eb to
182750b
Compare
Summary
CLI side of the swipe duration support merged in mobile-next/devicekit-ios#62. Adds an optional
--durationin milliseconds toio swipe.adb shell input swipe, defaulting to the 1000ms it has always used.Verified on an iPhone 11 (iOS 26.6)
Summary by CodeRabbit
--durationoption.