feat(apps): report version and versionCode for installed apps on all platforms - #347
Conversation
…platforms Android previously returned package names only. A new PackageLister class (port of devicekit-android's PackageLister.kt) is compiled into the embedded mobilecli.dex and run via app_process, returning name, versionName and versionCode for every package in one call. Works on API 26+ (int/long flags fallback for getInstalledPackages, getLongVersionCode fallback). iOS real devices and simulators now also return CFBundleVersion as versionCode, matching the existing utils.AppMetadata shape. Claude-Session: https://claude.ai/code/session_01VWnPxWoAPSFQTuYqB2ZT3L
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughInstalled app listings now expose ChangesInstalled app metadata
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant AndroidDevice
participant PackageLister
participant PackageManager
participant AndroidListApps
AndroidDevice->>PackageLister: Execute embedded DEX with app_process
PackageLister->>PackageManager: Query installed packages
PackageManager-->>PackageLister: Return package metadata
PackageLister-->>AndroidDevice: Return JSON records
AndroidDevice->>AndroidListApps: Parse records and filter launchable packages
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary by CodeRabbit
New Features
Bug Fixes