all: do not allow OPTIONS method in CORS config - #1223
Open
jub0bs wants to merge 1 commit into
Open
Conversation
Author
|
cc @orius123 (Thanks for recommending github.com/jub0bs/cors, by the way!) |
Contrary to popular belief, listing OPTIONS as an allowed method in a
server's CORS configuration is not necessary for CORS preflight to
succeed. It is only required if server developers wish to allow clients
to make explicit use of that method, e.g. via the following client code:
fetch('//example.com', {method: 'OPTIONS'})
This commit drops OPTIONS from the list of allowed methods throughout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrary to popular belief, listing OPTIONS as an allowed method in a server's CORS configuration is not necessary for CORS preflight to succeed. It is only required if server developers wish to allow clients to make explicit use of that method, e.g. via the following client code:
This commit drops OPTIONS from the list of allowed methods throughout.