test(markers): fix the scikit-learn requires_pkg marker - #2821
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2821 +/- ##
===========================================
+ Coverage 55.5% 73.4% +17.8%
===========================================
Files 644 659 +15
Lines 124135 132188 +8053
===========================================
+ Hits 68947 97044 +28097
+ Misses 55188 35144 -20044 🚀 New features to boost your workflow:
|
requires_pkg() resolves a distribution name and imports the matching module, and scikit-learn matches neither name on its own: the distribution is scikit-learn and the module is sklearn. test_save_load_node_mapping_structured was therefore skipped everywhere, including the nightly optional dependency build, and had never run. Map the distribution to its module so the test runs.
jdhughes-dev
force-pushed
the
fix-sklearn-marker
branch
from
August 23, 2026 06:04
3d91095 to
e097b31
Compare
wpbonelli
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires_pkg()resolves a distribution name and imports the matching module, soscikit-learn matches neither name on its own — the distribution is
scikit-learnand themodule is
sklearn.test_save_load_node_mapping_structuredwas skipped everywhere as aresult, including the nightly optional dependency build, and had never run.
name_map, asrequires_pkg()documents for this case