Skip to content

feat(tests): reserve balance violation reverting with its call frame - #55

Merged
pdobacz merged 1 commit into
forks/monad_ninefrom
tests/reserve-balance-frame-rollback
Sep 4, 2026
Merged

feat(tests): reserve balance violation reverting with its call frame#55
pdobacz merged 1 commit into
forks/monad_ninefrom
tests/reserve-balance-frame-rollback

Conversation

@pdobacz

@pdobacz pdobacz commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Covers the debiting frame and its enclosing frame unwinding, against the frame returning normally.

I've just realized we don't have an explicit test for this case (we have one in the MIP-4 family, but not here, where it belonged).

Greptile Summary

Adds explicit conformance coverage for reserve-balance violations across nested call-frame rollback behavior.

  • Exercises normal exits through STOP and RETURN.
  • Exercises reverted or exceptional exits through REVERT and INVALID.
  • Verifies behavior both with and without an enclosing frame reverting.
  • Checks transaction storage rollback and final account balances.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The expected storage and balance states consistently reflect whether the delegated EOA’s value debit survives its call frames and therefore triggers transaction-level reserve-balance rollback.

Important Files Changed

Filename Overview
tests/monad_eight/reserve_balance/test_transfers.py Adds a coherent parameterized test matrix for reserve-balance debit rollback across inner and enclosing call-frame outcomes.

Reviews (1): Last reviewed commit: "test a reserve balance violation reverti..." | Re-trigger Greptile

Covers the debiting frame and its enclosing frame unwinding, against the frame returning normally.

Co-Authored-By: Claude <claude-opus-5>
@pdobacz
pdobacz requested review from QEDK and mijovic as code owners September 3, 2026 15:20

@QEDK QEDK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pdobacz
pdobacz merged commit d0ba370 into forks/monad_nine Sep 4, 2026
10 checks passed
@pdobacz
pdobacz deleted the tests/reserve-balance-frame-rollback branch September 4, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants