feat(tests): reserve balance violation reverting with its call frame - #55
Merged
Merged
Conversation
Covers the debiting frame and its enclosing frame unwinding, against the frame returning normally. Co-Authored-By: Claude <claude-opus-5>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the debiting frame and its enclosing frame unwinding, against the frame returning normally.
I've just realized we don't have an explicit test for this case (we have one in the MIP-4 family, but not here, where it belonged).
Greptile Summary
Adds explicit conformance coverage for reserve-balance violations across nested call-frame rollback behavior.
STOPandRETURN.REVERTandINVALID.Confidence Score: 5/5
The PR appears safe to merge with no actionable correctness or security issues identified.
The expected storage and balance states consistently reflect whether the delegated EOA’s value debit survives its call frames and therefore triggers transaction-level reserve-balance rollback.
Important Files Changed
Reviews (1): Last reviewed commit: "test a reserve balance violation reverti..." | Re-trigger Greptile