Repository navigation
test: unflake customers docker and outbound IP checks - #672
Merged
Merged
Conversation
Watchman:static listens on :8084 and no longer EXPOSEs 8080, so
GetPort("8080/tcp") was empty and the tests dialed port 80. Check
every resolved address against the FTP/SFTP allow list so Cloudflare
round-robin on moov.io cannot fail TestRejectOutboundIPRange.
ubuntu-18.04 is no longer hosted, so the job queued forever. Use ubuntu-latest and the preinstalled Docker Compose v2 plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http://localhost/ping(port 80) becausemoov/watchman:staticnow listens on:8084and no longer EXPOSEs 8080, soGetPort("8080/tcp")was empty. Point the tests at 8084, use a Docker network instead of legacy links, and dial127.0.0.1.TestRejectOutboundIPRangefailed when Cloudflare returned a different A record thanaddrs[0](e.g.104.20.35.194). Match any resolved address against the allow list, and whitelist every IPv4//24in the test.Fixes the Ubuntu
Go Buildjob: https://github.com/moov-io/paygate/actions/runs/33641980132/job/100287068229Test plan
go test ./pkg/upload/ ./pkg/customers/ -count=1