Skip to content

build: split build targets into MakefileBuild.mk - #1074

Merged
FletcherMan merged 1 commit into
mainfrom
feat/split-makefile-build
Sep 24, 2026
Merged

FletcherMan merged 1 commit into
mainfrom
feat/split-makefile-build

Conversation

@Dino2049

@Dino2049 Dino2049 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Migrate to the new SPUG release system where build and deploy are separated. MakefileBuild.mk now holds all build-* targets (node, tx-submitter, gas-oracle, prover, challenge-handler, shadow-proving, token-price-oracle); MakefileEc2.mk/MakefileEks.mk keep only the start-* targets. Target names are unchanged.

Summary by CodeRabbit

  • Build and Deployment
    • Added build-artifact support for node, transaction submission, oracle, prover, challenge-handling, and shadow-proving services across mainnet, Qanet, and Hoodi.
    • Build artifacts are now produced separately from service start commands, keeping build and runtime workflows distinct.
    • Node and transaction-submission builds package and upload artifacts to their environment-specific destinations.

Migrate to the new SPUG release system where build and deploy are
separated. MakefileBuild.mk now holds all build-* targets (node,
tx-submitter, gas-oracle, prover, challenge-handler, shadow-proving,
token-price-oracle); MakefileEc2.mk/MakefileEks.mk keep only the
start-* targets. Target names are unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Dino2049
Dino2049 requested a review from a team as a code owner September 24, 2026 03:43
@Dino2049
Dino2049 requested review from dylanCai9 and removed request for a team September 24, 2026 03:43
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b60b5136-b679-4800-aea4-d18810d0f0a3

📥 Commits

Reviewing files that changed from the base of the PR and between aa35ed6 and 6425c0e.

📒 Files selected for processing (3)
  • MakefileBuild.mk
  • MakefileEc2.mk
  • MakefileEks.mk

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request adds build-artifact targets to MakefileBuild.mk for node, transaction-submitter, oracle, and Rust service binaries. It removes build targets from MakefileEc2.mk and MakefileEks.mk; MakefileEks.mk retains service start targets and adds a mainnet token-price-oracle start target.

Changes

Build and deployment targets

Layer / File(s) Summary
Node and tx-submitter artifact builds
MakefileBuild.mk
Adds build metadata and mainnet, qanet, and Hoodi targets that build binaries, stage them in dist, package them as tarballs, and upload them to environment-specific S3 paths.
Oracle and Rust service artifact builds
MakefileBuild.mk
Adds targets for gas-price-oracle, prover, challenge-handler, shadow-proving, and token-price-oracle. The targets build and stage binaries and retrieve the corresponding environment’s secret-manager wrapper. Prover, challenge-handler, and shadow-proving targets enable Git CLI fetches.
Deployment Makefile commands
MakefileEc2.mk, MakefileEks.mk
Removes build targets from both files. MakefileEc2.mk now contains a comment describing start and healthcheck target naming. MakefileEks.mk retains service start targets and adds a mainnet token-price-oracle start target.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 6425c

No actionable risk introduced by this split remains established. The change is mergeable after normal build checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: moving build targets into MakefileBuild.mk while separating build configuration from deployment files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@FletcherMan
FletcherMan merged commit da98eef into main Sep 24, 2026
7 checks passed
@FletcherMan
FletcherMan deleted the feat/split-makefile-build branch September 24, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants