Add TLS 1.3 cipher-suite scanning using a capable OpenSSL - #196
Open
SahandMas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-tls1_3and-ciphersuites;Approach
The bundled OpenSSL binaries remain unchanged for legacy protocol and cipher coverage. TLS 1.3 scanning uses the selected OpenSSL when it is capable, otherwise it falls back to a compatible system OpenSSL. If neither is available, CipherScan keeps the legacy scan results and emits a clear warning.
This keeps the patch focused on one file and avoids adding another binary to the repository.
Relation to existing work
This addresses #165. PR #169 proposed shipping OpenSSL 1.1.1 alongside a renamed legacy binary and included a larger refactor. This PR offers a smaller alternative that relies on an already-installed TLS 1.3-capable OpenSSL while preserving the current bundled binaries.
Validation
bash -n cipherscanpasses.