fix: AdLoaderAd dropping custom targeting on next-gen Android SDK - #4
Open
felipefuzaro-funda wants to merge 2 commits into
Open
Conversation
AdLoaderAd dropping custom targeting on next-gen Android AdLoaderAd dropping custom targeting on next-gen Android SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the next-gen Android SDK (
USE_NEXT_GEN_SDK=true,ads-mobile-sdk:1.1.1),AdLoaderAdrequests were built without applying the ad request, so customtargeting, keywords, content URL, neighboring URLs, request agent, and PPID were
dropped. Targeted line items didn't match → No fill. Legacy play-services
and iOS were unaffected.
Fix
FlutterAdRequest(next-gen): addconfigureNativeAdRequestBuilder(...)toapply common request fields to
NativeAdRequest.Builder.FlutterAdManagerAdRequest(next-gen): override to also apply customtargeting, targeting lists, and PPID.
FlutterAdLoader(next-gen): thread the request intoloadAdLoaderAd/loadAdManagerAdLoaderAdand apply it before load.FlutterAdLoaderAd(next-gen): pass the request through inload().AdMessageCodec: guard nulldomain/messagewhen decodingLoadAdError/AdError(previously threw and masked the No-fill as a crash).Tests
domain/messagedecoding.flutter analyzeclean; full Dart suite passes; example app compiles with--dart-define=USE_NEXT_GEN_SDK=true.Notes
asGAMRequest:; no change needed.