Update environment stuff - #444
Merged
Merged
Conversation
GitMensch
approved these changes
Aug 29, 2026
GitMensch
left a comment
GitMensch
left a comment
Contributor
There was a problem hiding this comment.
Thanks for those reasonable changes.
One unrelated comment to the porting make part below.
Comment on lines
10
to
12
| mingw32-make | ||
| ------------ | ||
| MSYS2 provides two versions of make, one in the `make` package and one in the `mingw-w64-{i686,x86_64}-make` packages. The latter one is called `mingw32-make` on command line, is fully native and doesn't depend on `msys2` shells. The downside is that it doesn't work with many `Makefile`s. Unless you know what you're doing, use the regular `make`. |
Contributor
There was a problem hiding this comment.
Does this need any adjustment? If not then maybe we should keep mingw32-make only as a compatibility name "symlink" and rename it.
Member
Author
There was a problem hiding this comment.
I'm not aware of any improvements in mingw32-make's compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@GitMensch 👋