Skip to content

Detekt > ReturnCount = 3 - #88

Merged
mmathieum merged 1 commit into
masterfrom
mm/Detekt_ReturnCount
Sep 1, 2026
Merged

Detekt > ReturnCount = 3#88
mmathieum merged 1 commit into
masterfrom
mm/Detekt_ReturnCount

Conversation

@mmathieum

Copy link
Copy Markdown
Member

@mmathieum mmathieum self-assigned this Sep 1, 2026
@mmathieum
mmathieum marked this pull request as ready for review September 1, 2026 14:34
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 183e1dee-cb7f-44fd-93d8-87023515c69e

📥 Commits

Reviewing files that changed from the base of the PR and between 0e0eaa5 and 715ea3c.

📒 Files selected for processing (1)
  • detekt-baseline.xml
💤 Files with no reviewable changes (1)
  • detekt-baseline.xml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Removed obsolete code-quality warnings for file formatting and excessive return statements.
    • Updated static analysis baselines to reflect resolved issues.

Walkthrough

The Detekt baseline removes 15 suppressions for resolved newline and return-count findings.

Changes

Detekt baseline cleanup

Layer / File(s) Summary
Remove obsolete suppressions
detekt-baseline.xml
Removes the NewLineAtEndOfFile suppression for GStop.kt and 14 ReturnCount suppressions for selected Kotlin functions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 715ea

This is a narrowly scoped static-analysis baseline cleanup, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Detekt ReturnCount threshold change to 3.
Description check ✅ Passed The description references the related mtransitapps/commons pull request and is relevant to the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mm/Detekt_ReturnCount

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mmathieum
mmathieum merged commit ece2d7b into master Sep 1, 2026
5 checks passed
@mmathieum
mmathieum deleted the mm/Detekt_ReturnCount branch September 1, 2026 19:38
montransit added a commit to mtransitapps/mtransit-for-android that referenced this pull request Sep 1, 2026
…parser':

- commons: Detekt > `ReturnCount` = 3 mtransitapps/commons#851
- commons-android: Detekt > `ReturnCount` = 3 mtransitapps/commons-android#197
- commons-java: Detekt > `ReturnCount` = 3 mtransitapps/commons-java#48
- parser: Detekt > `ReturnCount` = 3 mtransitapps/parser#88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant