Fail on empty required files

[mmathieum]

No description provided.

[coderabbitai]

Warning

Review limit reached

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 16fe6409-6994-4e91-bf9f-db7985a6835b

📥 Commits

Reviewing files that changed from the base of the PR and between 07e869c and ba6c286.

📒 Files selected for processing (1)

• src/main/java/org/mtransit/parser/gtfs/GReader.java

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 1701289c-6ac0-432c-aa55-e34e4fe56084

📥 Commits

Reviewing files that changed from the base of the PR and between 0e0eaa5 and 07e869c.

📒 Files selected for processing (1)

• src/main/java/org/mtransit/parser/gtfs/GReader.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved validation for required GTFS files.
  • Files containing headers but no data now trigger a clear fatal error.
  • Empty or invalid CSV input is handled more reliably.

Walkthrough

GTFS CSV reading now returns the number of processed data lines. Required files with no data lines raise a fatal error. Optional missing files remain skipped. The unused no-callback overload was removed.

Changes

GTFS empty-file validation

Layer / File(s)	Summary
CSV line counting and required-file validation src/main/java/org/mtransit/parser/gtfs/GReader.java	readCsv returns 0 for empty input or headers and returns the processed data-line count. readFiles uses this count to reject empty required files while continuing to skip missing optional files.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 07e86

The parser now fails closed when a required GTFS file contains no processed data rows, while optional-file handling remains unchanged. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The pull request has no description, so it provides no meaningful context about the changes.	Add a brief description that explains how empty required files are detected and that the parser now raises a fatal error for them.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: required empty files now cause a failure.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mm/empty_required_files

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟢 Approval recommended

The behavioral change is localized and consistent with required-file validation, with only a minor log-message typo noted.

Pull request overview

This PR tightens GTFS ingestion in GReader by failing fast when a required GTFS file is present but contains no data rows, preventing downstream parsing from proceeding with invalid/empty required inputs.

Changes:

• Treat required GTFS files with zero processed data lines as fatal (fail-fast).
• Refactor readCsv(...) to return the number of processed records so callers can enforce required-file non-emptiness.
• Clarify the fatal error message when a required file is missing.

File summaries

File	Description
src/main/java/org/mtransit/parser/gtfs/GReader.java	Enforces “required file must not be empty” by returning/validating processed line counts from CSV parsing.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.