🐛 Fix shared-library builds and packaging - #2353
Closed
burgholzer wants to merge 1 commit into
Closed
burgholzer wants to merge 1 commit into
burgholzer wants to merge 1 commit into
Conversation
Keep internal compiler and jeff libraries static so installed QDMI devices do not depend on unexported compiler shared libraries. Use CMake's build-tree RPATH and place the shared QDMI driver beside its device manifests. Run the existing Linux Debug CI lane with global BUILD_SHARED_LIBS enabled to cover configuration and runtime loading. Assisted-by: Codex
Member
Author
|
Closing this one. We do not build with |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Fix the
BUILD_SHARED_LIBS=ONconfiguration failure noted in #2352, now merged intomain.debug-sharedpreset and use it in the existing Linux Debug CI job. Document the linkage policy.Validation on Linux ARM64 with LLVM/MLIR 23.1.0:
find_package(mqt-core)consumer. It discovered and loaded DDSIM without compiler targets or private compiler shared libraries.uvx nox -s lintandgit diff --checkpassed. No C++ sources changed.Codex assisted with implementation, validation, and this description. No standalone changelog entry is added for this unreleased compiler infrastructure fix.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).