Skip to content

CMR-11429 warnings about libs overwriting built in clojure functions - #2494

Draft
jceaser wants to merge 18 commits into
masterfrom
cmr-11429-libs-over-clojure
Draft

CMR-11429 warnings about libs overwriting built in clojure functions#2494
jceaser wants to merge 18 commits into
masterfrom
cmr-11429-libs-over-clojure

Conversation

@jceaser

@jceaser jceaser commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Overview

While working on https://bugs.earthdata.nasa.gov/browse/CMR-11368 an attempt was made to clean up some long standing warnings in the compile logs related to libraries trying to overwrite built in clojure functions. These log entries were getting in the way and making it hard to read other errors of interest. So, some time was taken to resolve those issues.

These changes are all the changes which were not directly related to CMR-11368, since there were two tickets this one is used for the overflow changes allowing each set of changes to have their own life cycle.

Example of removed warnings

WARNING: update-vals already refers to: #'clojure.core/update-vals in namespace: clojure.tools.analyzer.utils, being replaced by: #'clojure.tools.analyzer.utils/update-vals
WARNING: update-keys already refers to: #'clojure.core/update-keys in namespace: clojure.tools.analyzer.utils, being replaced by: #'clojure.tools.analyzer.utils/update-keys
WARNING: update-vals already refers to: #'clojure.core/update-vals in namespace: clojure.tools.analyzer, being replaced by: #'clojure.tools.analyzer.utils/update-vals
WARNING: update-keys already refers to: #'clojure.core/update-keys in namespace: clojure.tools.analyzer, being replaced by: #'clojure.tools.analyzer.utils/update-keys
WARNING: update-vals already refers to: #'clojure.core/update-vals in namespace: clojure.tools.analyzer.passes, being replaced by: #'clojure.tools.analyzer.utils/update-vals
WARNING: update-vals already refers to: #'clojure.core/update-vals in namespace: clojure.tools.analyzer.passes.uniquify, being replaced by: #'clojure.tools.analyzer.utils/update-vals
WARNING: abs already refers to: #'clojure.core/abs in namespace: medley.core, being replaced by: #'medley.core/abs

What are the changes?

  • [compojure "1.6.3"]
  • [nrepl/nrepl "1.1.0"]
  • [org.clojure/core.cache "1.0.225"]
  • [org.clojure/test.check "1.1.1"]
  • [org.clojure/tools.reader "1.4.0"]

Required Checklist

  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors in changed files are corrected
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation (if necessary)
  • My changes generate no new warnings in fact less!!!!!!!!

@jceaser
jceaser requested review from DuJuan, daniel-zamora, eereiter, jaortega527, jmaeng72 and zimzoom and removed request for DuJuan September 4, 2026 19:03
@codecov-commenter

codecov-commenter commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.95%. Comparing base (696964a) to head (b201e5d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2494   +/-   ##
=======================================
  Coverage   57.95%   57.95%           
=======================================
  Files        1074     1074           
  Lines       74707    74707           
  Branches     2191     2189    -2     
=======================================
  Hits        43294    43294           
  Misses      29365    29365           
  Partials     2048     2048           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants