CMR-11429 warnings about libs overwriting built in clojure functions - #2494
Draft
jceaser wants to merge 18 commits into
Draft
CMR-11429 warnings about libs overwriting built in clojure functions#2494jceaser wants to merge 18 commits into
jceaser wants to merge 18 commits into
Conversation
…ge write status better
…ing the other testing threads
…he logs complaining about clojure libraries being replaced
… a version number
jceaser
requested review from
DuJuan,
daniel-zamora,
eereiter,
jaortega527,
jmaeng72 and
zimzoom
and removed request for
DuJuan
September 4, 2026 19:03
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2494 +/- ##
=======================================
Coverage 57.95% 57.95%
=======================================
Files 1074 1074
Lines 74707 74707
Branches 2191 2189 -2
=======================================
Hits 43294 43294
Misses 29365 29365
Partials 2048 2048 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
While working on https://bugs.earthdata.nasa.gov/browse/CMR-11368 an attempt was made to clean up some long standing warnings in the compile logs related to libraries trying to overwrite built in clojure functions. These log entries were getting in the way and making it hard to read other errors of interest. So, some time was taken to resolve those issues.
These changes are all the changes which were not directly related to CMR-11368, since there were two tickets this one is used for the overflow changes allowing each set of changes to have their own life cycle.
Example of removed warnings
WARNING: update-vals already refers to: #'clojure.core/update-vals in namespace: clojure.tools.analyzer.utils, being replaced by: #'clojure.tools.analyzer.utils/update-vals
WARNING: update-keys already refers to: #'clojure.core/update-keys in namespace: clojure.tools.analyzer.utils, being replaced by: #'clojure.tools.analyzer.utils/update-keys
WARNING: update-vals already refers to: #'clojure.core/update-vals in namespace: clojure.tools.analyzer, being replaced by: #'clojure.tools.analyzer.utils/update-vals
WARNING: update-keys already refers to: #'clojure.core/update-keys in namespace: clojure.tools.analyzer, being replaced by: #'clojure.tools.analyzer.utils/update-keys
WARNING: update-vals already refers to: #'clojure.core/update-vals in namespace: clojure.tools.analyzer.passes, being replaced by: #'clojure.tools.analyzer.utils/update-vals
WARNING: update-vals already refers to: #'clojure.core/update-vals in namespace: clojure.tools.analyzer.passes.uniquify, being replaced by: #'clojure.tools.analyzer.utils/update-vals
WARNING: abs already refers to: #'clojure.core/abs in namespace: medley.core, being replaced by: #'medley.core/abs
What are the changes?
Required Checklist