Conversation
This package's own suite dispatches on a test dialect, which is what keeps it free of database dependencies -- and also means nothing in it can catch a change that breaks a real dialect. That signal only exists downstream, so this brings it back to where the change is made. Each leg installs the dialect's dependencies, then overwrites sqlr with the build from this branch, then runs the dialect's suite. Two steps guard against a green run that tested nothing: one fails if the overwrite did not take and main's sqlr is still installed, the other fails if the postgres service is unreachable, since the round-trip tests skip themselves in that case and a skip reads as a pass in the summary.
nbenn
marked this pull request as ready for review
August 29, 2026 06:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nbenn/sqlr.postgresandnbenn/sqlr.sqlitetest suites against the sqlr built from the branch under test, so a core change that breaks a dialect fails here rather than in a downstream repo hours later.Remotes: nbenn/sqlrcopy pulled from main; the other asserts the Postgres service is reachable, since the round-trip tests skip themselves when it is not and a skip is indistinguishable from a pass in the summary line.BristolMyersSquibb/blockr.ci, with three deliberate departures: it is a plain workflow rather than a reusable one (a single upstream, not an org of them), it triggers onpull_requestrather thanmerge_group(this repo has no merge queue, somerge_groupwould never fire), and it runs the dialect suites rather than a fullR CMD checkon each.The
revdep-allaggregator gives branch protection one stable check name, so adding a dialect to the matrix does not mean editing the required-checks list.