π Improve public repository readiness - #8
Conversation
Leverframe reviewπ‘ Review completed in 371s
Changes |
There was a problem hiding this comment.
Leverframe review
One low-severity documentation defect found. Review used the repository-pinned pnpm 11.23.0 with Node v24.20.0. The full prescribed quality gate passed, and all changed files were materially inspected.
Findings
1 finding was published inline.
Checks
6 passed Β· 0 failed Β· 0 not run
Show 6 checks
| Status | Check | Evidence |
|---|---|---|
| π’ passed | git diff --check 3169bd993f8492089316aecf6a2c1e6e39dc21ec...a24a70069534d36a72f65283d7780b068ffc39f6 |
No whitespace errors. |
| π’ passed | pnpm install --frozen-lockfile |
Installed 329 packages using repository-pinned pnpm 11.23.0 under Node v24.20.0; lockfile and supply-chain policy verification passed. |
| π’ passed | pnpm check |
Formatting, oxlint/eslint, TypeScript, 11 unit/integration test files with 40 tests, and the Node 24 production build all passed. |
| π’ passed | pnpm dlx yaml --json --single --strict ... | jq ... |
Both issue forms and the issue-template configuration parsed as strict YAML and satisfied their required structural constraints. |
| π’ passed | Local Markdown target check and curl checks for added external URLs |
All local links resolve. The OpenAI tunnel guide, Docker Sandboxes documentation, CI workflow/badge, and badge endpoints responded successfully; the new SECURITY.md link resolves at the reviewed head SHA. |
| π’ passed | pnpm pack --dry-run |
Produced a valid chat2shell@0.2.0 package manifest containing the built CLI and documented package files. |
Limitations
- Docker Sandboxes (
sbx) was unavailable, so the real E2E suite was not run. No sandbox/runtime code changed, and repository guidance assigns this documentation-only change to the normalpnpm checkboundary.
| ## Configuration | ||
|
|
||
| `.env.example` contains deployment locations and the tunnel switch. Sandbox authority and lifetime values are fixed policy, not environment-specific behavior. | ||
| The defaults are intentionally small. `.env.example` contains the complete set of environment overrides. |
There was a problem hiding this comment.
π΅ [LOW] The advertised complete environment template omits a supported override
This newly claims that .env.example contains every environment override, but loadAppConfig reads CHAT2SHELL_DATABASE_PATH and that variable is absent from both .env.example and the new configuration table. Users relying on the promised exhaustive template cannot discover or reproduce deployments that place the SQLite database separately from the state directory.
Evidence: src/config.ts:68-70 resolves environment.CHAT2SHELL_DATABASE_PATH, while .env.example contains nine other CHAT2SHELL_* variables but no database-path entry.
Suggested action: Add CHAT2SHELL_DATABASE_PATH to .env.example and document it in the table, or qualify the completeness claim and identify where all supported overrides are documented.
Confidence: high
Summary
Verification
pnpm format:check && pnpm lint && pnpm typecheckβ passed with no lint warnings or errors.vitest run --project unit --project integrationβ 40 tests across 11 files passed.tsdownβ production CLI bundle built successfully.npm packplus a temporary global install β the packagedchat2shell --helpcommand ran successfully.Notes
This change is documentation and repository metadata only; it does not change runtime behavior.