feat(i18n): overhaul translations and keep language dropdown inside a… - #3499
Open
Natixe wants to merge 1 commit into
Open
feat(i18n): overhaul translations and keep language dropdown inside a…#3499Natixe wants to merge 1 commit into
Natixe wants to merge 1 commit into
Conversation
…pp window Overhaul the Arabic, French, and Spanish localization catalogs and fix the language dropdown positioning so it always remains accessible inside the app window. The language dropdown was fixed-positioned without coordinates, so it fell back to its static position and grew downwards from the middle of the dialog. With 9 locales at 56px each (~536px of list), it ran past the bottom of the window and the last languages were unreachable. Its `max-height: calc(100vh - 400px)` used a hardcoded offset that did not match where the trigger actually sits, causing overflow on tall windows and truncating the list too early on short ones. Language dropdown changes: - compute the dropdown placement dynamically from the trigger's bounding rect - set top, left, width, and max-height based on the available space up to the window edge - keep the locale list scrollable inside the dropdown instead of overflowing outside the page - flip the dropdown upwards when there is not enough room below and more space is available above - reposition the dropdown on window resize - reposition it on scroll using the capture phase, since the dialog content can scroll and a fixed dropdown would otherwise detach from its trigger - close the dropdown when the dialog closes to avoid reopening it at a stale position - remove the hardcoded width, max-height, and margin rules from the stylesheet Internationalization changes: - improve and harmonize UI and Wallet translations in Arabic, French, and Spanish - add missing translation keys and remove incorrect keys - fix placeholders, HTML tags, and CLDR plural forms - standardize technical terminology related to CKB and Neuron - remove remaining English strings and typographical errors - add an i18n audit script to automatically validate translation catalogs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhaul the Arabic, French, and Spanish localization catalogs and fix the
language dropdown positioning so it always remains accessible inside the app
window.
The language dropdown was fixed-positioned without coordinates, so it fell back
to its static position and grew downwards from the middle of the dialog. With 9
locales at 56px each (~536px of list), it ran past the bottom of the window and
the last languages were unreachable. Its
max-height: calc(100vh - 400px)useda hardcoded offset that did not match where the trigger actually sits, causing
overflow on tall windows and truncating the list too early on short ones.
Language dropdown changes:
y from the trigger's bounding rect
window edge
outside the page
is available above
scroll and a fixed dropdown would otherwise detach from its trigger
position
Internationalization changes:
(Basically, adding to and improving the work I had already done )