[NAE-2478] Persist Sorting in User Preference Data - #347
Open
renczesstefan wants to merge 7 commits into
Open
Conversation
Introduced sorting support for headers by updating preferences, services, and UI components. This includes saving sort states, updating the header's edit mode, and enhancing the user interface with icons for sorting interactions.
Updated SCSS to fix alignment issues, adjust padding, and refine icon styles. Simplified HTML layout to ensure consistent spacing and applied new class names for better styling consistency. Changes improve usability and maintainability.
Updated SCSS to fix alignment issues, adjust padding, and refine icon styles. Simplified HTML layout to ensure consistent spacing and applied new class names for better styling consistency. Changes improve usability and maintainability.
Revised sorting functionality to improve header sorting behavior, including new functions for updating and saving sort modes. Adjusted styles and HTML for better UI consistency, and introduced `sortingHeaderSelected` to manage sort direction changes effectively.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Previously, a warning was logged when sorting headers could not be restored from preferences. This change simplifies the code by removing the warning, as it does not impact functionality and reduces log noise.
Replaced the `setHeaders` method with a new `setHeadersAndSorts` method to handle headers and sorts together. This enhances consistency and readability by centralizing the logic for updating preferences. Adjusted references in the `abstract-header-service` to use the updated method.
This update introduces the getSorts method to the mock service, returning undefined by default. It ensures consistency with expected service behavior during tests.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements NAE-2478
Dependencies
No new dependencies were introduced
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
This was tested manually and with unit tests.
Test Configuration
Checklist: