Skip to content

parse: don't dereference the end of the token vector in a media list #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
metan-ucw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

parse: don't dereference the end of the token vector in a media list #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/parse/mq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,7 @@ static css_error mq_parse_media_query(lwc_string **strings,
token = parserutils_vector_peek(vector, *ctx);
if (tokenIsChar(token, '(')) {
is_condition = true;
} else if (token->type == CSS_TOKEN_IDENT &&
} else if (token != NULL && token->type == CSS_TOKEN_IDENT &&
lwc_string_caseless_isequal(token->idata,
strings[NOT], &match) == lwc_error_ok &&
match) {
Expand Down
23 changes: 23 additions & 0 deletions test/data/parse2/mq.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,26 @@
#expected
| @media 3ff
#reset

## A media list with trailing comma crashed css__mq_parse_media_list() loop

#data
@media),
#errors
#expected
| @media not 3ff
#reset

#data
@media ),,,
#errors
#expected
| @media not 3ff
#reset

#data
@media (color),
#errors
#expected
| @media 3ff
#reset