Close and reopen security agent logs - #411
Open
rvansa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An application run with
-Dnewrelic.config.security.agent.enabled=true -Dnewrelic.config.security.enabled=truecannot be checkpointed as these two logs remain open.Some concerns I would like the reviewer to clear up:
shadowIntoJar, but since the mainnewrelic-java-agentshadowsorg.crac:cracas well, are we duplicating this? Could we have only shared instance?LogFileHelper.performDailyRollover(), though, and this does not use any synchronization when updating non-volatile field. The C/R code is affected the same way as regular logging code.Thank you!