Skip to content

Close and reopen security agent logs - #411

Open
rvansa wants to merge 1 commit into
newrelic:mainfrom
rvansa:crac_main
Open

Close and reopen security agent logs#411
rvansa wants to merge 1 commit into
newrelic:mainfrom
rvansa:crac_main

Conversation

@rvansa

@rvansa rvansa commented Aug 21, 2026

Copy link
Copy Markdown

An application run with -Dnewrelic.config.security.agent.enabled=true -Dnewrelic.config.security.enabled=true cannot be checkpointed as these two logs remain open.

Some concerns I would like the reviewer to clear up:

  • I have not checked the exact semantics of shadowIntoJar, but since the main newrelic-java-agent shadows org.crac:crac as well, are we duplicating this? Could we have only shared instance?
  • Exceptions thrown when closing the logs are silently swallowed; should I just print them to stderr?
  • The synchronization through the executor should be safe with regards to regular logging; there's LogFileHelper.performDailyRollover(), though, and this does not use any synchronization when updating non-volatile field. The C/R code is affected the same way as regular logging code.

Thank you!

@CLAassistant

CLAassistant commented Aug 21, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants