fix(templates): avoid extra file write - #5971
Open
elzody wants to merge 3 commits into
Open
Conversation
elzody
force-pushed
the
fix/template-antivirus-double-scan
branch
from
August 10, 2026 22:26
4392198 to
b19aff9
Compare
Avoids an extra file write when no template fields are provided. Not only does this avoid an extra write to the file, but it consequently also prevents the files_antivirus app from doing a second, sequential scan on the file; this should reduce the latency between creating a file and seeing it. Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-sonnet-4-6
elzody
force-pushed
the
fix/template-antivirus-double-scan
branch
from
August 12, 2026 16:03
b19aff9 to
0e10eea
Compare
The Save As exportmenubutton in the notebookbar is built with an empty SaveAsMenu (and thus a disabled container) when the File tab panel first renders before LibreOffice Core has reported the document type. Clicking a disabled container returns immediately without opening the dropdown, causing the #saveas-entries > div assertion to time out. Assert that the button's parent container does not have the disabled attribute before clicking. Cypress retries this assertion until the notebookbar rebuilds with the correct document type and a populated SaveAsMenu, at which point the click reliably opens the dropdown. Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids an extra file write when no template fields are provided. Not only does this avoid an extra write to the file, but it consequently also prevents the files_antivirus app from doing a second, sequential scan on the file; this should reduce the latency between creating a file and seeing it.
Assisted-by: ClaudeCode:claude-sonnet-4-6
Checklist