Add NI_IRQ_RESOLVER - #289
Open
alispss wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds NI’s Zynq interrupt resolver for translating Device Tree hardware IRQ specifications into Linux virtual IRQs.
Changes:
- Adds and exports the IRQ resolver.
- Introduces its Kconfig and build integration.
- Enables it in the NI Zynq defconfig.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
drivers/misc/niirqresolver.c |
Implements the IRQ resolver API. |
drivers/misc/Makefile |
Builds the resolver when configured. |
drivers/misc/Kconfig |
Defines the Zynq-specific option. |
arch/arm/configs/nati_zynq_defconfig |
Enables the resolver for NI Zynq targets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| return virq; | ||
| } | ||
| EXPORT_SYMBOL(ni_of_resolve_irq); |
Author
There was a problem hiding this comment.
Doesn't this defeat the purpose of what I'm trying to do with this PR? @chaitu236 can I safely ignore this suggestion?
chaitu236
requested changes
Aug 19, 2026
alispss
force-pushed
the
users/almontag/zynq-irq-6.18
branch
3 times, most recently
from
August 20, 2026 13:34
ab07afe to
2439c0e
Compare
Adds a resolver that translates hwirqs to virq for use by NI proprietary drivers. In previous kernels, they were equivalent, but in 6.18, they are no longer guaranteed. Required on zynq targets. Signed-off-by: Alison Montag <alison.montag@emerson.com>
alispss
force-pushed
the
users/almontag/zynq-irq-6.18
branch
from
August 20, 2026 20:06
2439c0e to
9f08316
Compare
bstreiff
requested changes
Aug 20, 2026
| CONFIG_BLK_DEV_RAM=y | ||
| CONFIG_BLK_DEV_RAM_SIZE=16384 | ||
| CONFIG_SRAM=y | ||
| CONFIG_NI_IRQ_RESOLVER=y |
Contributor
There was a problem hiding this comment.
bluefin and slsc have no need for this, neither of them use nikal-based drivers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a resolver that translates hwirqs to virq for use by NI proprietary drivers. In previous kernels, they were equivalent, but in 6.18, they are no longer guaranteed.
Required on zynq targets.
Testing:
I compiled a new BSI with this kernel change and deployed it to the target. Using an updated driver that corresponds with these changes, I was able observe successful interrupt reservation and deploy and run a VI on the Target.