Skip to content

Enable ni-RFSA grpc codegen - #2196

Merged
vnktshr21 merged 4 commits into
ni:masterfrom
mohit-emerson:rfsa_python_grpc
Aug 19, 2026
Merged

Enable ni-RFSA grpc codegen#2196
vnktshr21 merged 4 commits into
ni:masterfrom
mohit-emerson:rfsa_python_grpc

Conversation

@mohit-emerson

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.
  • [] I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Added RFSA grpc proto, grpc interpreter templates.
  • Added RFSA generated files.
  • Added RFSA Grpc System tests and config file.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

  • PR Validations
  • Tested using grpc local server, grpc remote server. All tests passing.

@mohit-emerson mohit-emerson changed the title Rfsa python grpc Enable ni-RFSA grpc codegen Aug 19, 2026
@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.48845% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.51%. Comparing base (c704deb) to head (9ad670f).

Files with missing lines Patch % Lines
generated/nirfsa/nirfsa/_grpc_stub_interpreter.py 83.03% 47 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
+ Coverage   88.49%   88.51%   +0.02%     
==========================================
  Files          80       82       +2     
  Lines       21380    21679     +299     
==========================================
+ Hits        18921    19190     +269     
- Misses       2459     2489      +30     
Flag Coverage Δ
codegenunittests 84.90% <ø> (ø)
nidcpowersystemtests 94.38% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.02% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.29% <ø> (ø)
nifakeunittests 86.01% <ø> (ø)
nifgensystemtests 94.32% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 82.66% <84.48%> (+0.89%) ⬆️
nirfsgsystemtests 81.12% <ø> (ø)
niscopesystemtests 89.96% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.56% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nirfsa/nirfsa/_library_interpreter.py 77.99% <100.00%> (+0.03%) ⬆️
generated/nirfsa/nirfsa/grpc_session_options.py 100.00% <100.00%> (ø)
generated/nirfsa/nirfsa/session.py 88.20% <100.00%> (+0.06%) ⬆️
generated/nirfsa/nirfsa/_grpc_stub_interpreter.py 83.03% <83.03%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c704deb...9ad670f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mohit-emerson
mohit-emerson marked this pull request as ready for review August 19, 2026 06:50
@vnktshr21
vnktshr21 merged commit 45664f2 into ni:master Aug 19, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants