Skip to content

Add new deembedding type in NI-RFSA - #2199

Merged
vnktshr21 merged 2 commits into
ni:masterfrom
mohit-emerson:rfsa_add_new_deembedding_type
Aug 20, 2026
Merged

Add new deembedding type in NI-RFSA#2199
vnktshr21 merged 2 commits into
ni:masterfrom
mohit-emerson:rfsa_add_new_deembedding_type

Conversation

@mohit-emerson

@mohit-emerson mohit-emerson commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.
  • [ ] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • AMPLITUDE_FLATNESS added to enum DeembeddingType.

List issues fixed by this Pull Request below, if any.

What testing has been done?

  • A successful tox execution.
  • PR Validations

@mohit-emerson
mohit-emerson marked this pull request as ready for review August 20, 2026 12:02
@codecov-commenter

codecov-commenter commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (b7a6c22) to head (1809f9a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2199   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files          82       82           
  Lines       21679    21679           
=======================================
+ Hits        19189    19190    +1     
+ Misses       2490     2489    -1     
Flag Coverage Δ
codegenunittests 84.90% <ø> (ø)
nidcpowersystemtests 94.38% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.02% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.29% <ø> (ø)
nifakeunittests 86.01% <ø> (ø)
nifgensystemtests 94.32% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 82.66% <ø> (ø)
nirfsgsystemtests 81.12% <ø> (ø)
niscopesystemtests 89.96% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.56% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nirfsa/nirfsa/session.py 88.20% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a6c22...1809f9a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vnktshr21
vnktshr21 merged commit cff22c9 into ni:master Aug 20, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants