Add new deembedding type in NI-RFSA - #2199
Merged
vnktshr21 merged 2 commits intoAug 20, 2026
Merged
Conversation
mohit-emerson
marked this pull request as ready for review
August 20, 2026 12:02
mohit-emerson
requested review from
marcoskirsch,
ni-jfitzger and
vnktshr21
as code owners
August 20, 2026 12:02
vnktshr21
approved these changes
Aug 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2199 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 82 82
Lines 21679 21679
=======================================
+ Hits 19189 19190 +1
+ Misses 2490 2489 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] I've updated CHANGELOG.md if applicable.[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
AMPLITUDE_FLATNESSadded to enumDeembeddingType.List issues fixed by this Pull Request below, if any.
What testing has been done?