verify authentication code for zero-length winzip aes entries - #563
Closed
arshsmith1 wants to merge 1 commit into
Closed
verify authentication code for zero-length winzip aes entries#563arshsmith1 wants to merge 1 commit into
arshsmith1 wants to merge 1 commit into
Conversation
dillof
added a commit
that referenced
this pull request
Aug 19, 2026
…` was never called. Fixes PR #563 and security advisory GHSA-c4x8-wr2m-r7x6
Member
|
Thanks for the bug report and test case. We've fixed it slightly differently so the error gets reported when closing the source (even without ever reading from it) instead of when opening it. This is in line with all the other end-of-file consistency checks done by sources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying the hmac in ZIP_SOURCE_OPEN when data_length is 0 gets it rejected with ZIP_ER_CRC like any other tampered entry. The regress archive has an empty AES-256 entry with a corrupted hmac; reading it with the right password fails now and would pass before.