Skip to content

Request a token for nodejs/undici - #1072

Merged
legendecas merged 3 commits into
nodejs:mainfrom
avivkeller:patch-7
Aug 10, 2026
Merged

Request a token for nodejs/undici#1072
legendecas merged 3 commits into
nodejs:mainfrom
avivkeller:patch-7

Conversation

@avivkeller

@avivkeller avivkeller commented Jun 23, 2026

Copy link
Copy Markdown
Member

Permissions required: actions: write (for nodejs/undici-website)

This token will be used to automatically re-deploy the website when a new version of Undici releases.

See: https://undici.nodejs.org/
Ref: nodejs/undici#5438

@mcollina

Copy link
Copy Markdown
Member

write permission to what repo?

@avivkeller

Copy link
Copy Markdown
Member Author

Ack! Sorry! undici-website

@avivkeller

Copy link
Copy Markdown
Member Author

Bump @mcollina

@avivkeller

Copy link
Copy Markdown
Member Author

Bump @nodejs/TSC

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@legendecas

legendecas commented Aug 10, 2026

Copy link
Copy Markdown
Member

IIUC, this token is used to write to repo undici-website from a workflow in undici, and it needs contents: write, right? The OP says actions: write. Could you clarify on this? Thanks!

@legendecas

Copy link
Copy Markdown
Member

Oh, I think it invokes with createWorkflowDispatch in https://github.com/nodejs/undici/pull/5449/changes so actions: write is sufficient.

@avivkeller

Copy link
Copy Markdown
Member Author

HI! Yes, it just triggers an action, not direct write

Comment thread request-an-access-token.md Outdated
@legendecas
legendecas merged commit 873e498 into nodejs:main Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants