test: accept decoder errors for wrong FIPS passphrases - #65075
Open
Archkon wants to merge 1 commit into
Open
Conversation
Wrong-passphrase CBC decryption can occasionally produce valid padding. OpenSSL then parses the invalid plaintext and reports ASN.1 or decoder errors instead of bad decrypt. Accept these equivalent failures for FIPS-generated keys while keeping strict checks for fixed non-FIPS fixtures. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Contributor
Author
|
ping @panva |
panva
approved these changes
Aug 6, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65075 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.01%
==========================================
Files 759 759
Lines 247646 247754 +108
Branches 46697 46725 +28
==========================================
+ Hits 223654 223740 +86
- Misses 15463 15481 +18
- Partials 8529 8533 +4 🚀 New features to boost your workflow:
|
Contributor
Author
|
@panva Could you have the failed macos check try again? It seems that so unlucky enough to trigger the flaky test a second time. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrong-passphrase CBC decryption can occasionally produce valid padding. OpenSSL then parses the invalid plaintext and reports ASN.1 or decoder errors instead of bad decrypt.
To fix the flaky test that encountered at https://github.com/nodejs/node/actions/runs/31081775174/job/92552480382