tools: label PRs lacking second approval - #65538
Open
panva wants to merge 1 commit into
Open
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
jasnell
approved these changes
Aug 25, 2026
panva
added a commit
to nodejs/node-auto-test
that referenced
this pull request
Aug 26, 2026
Enable the commit queue in node-auto-test. Treat queued PRs as aged so PR 103 exercises the approval label. PR-URL: nodejs/node#65538 Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
added a commit
to nodejs/node-auto-test
that referenced
this pull request
Aug 26, 2026
Enable the commit queue in node-auto-test. Treat queued PRs as aged so PR 103 exercises the approval label. PR-URL: nodejs/node#65538 Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Member
Author
|
Tested in
|
panva
marked this pull request as ready for review
August 26, 2026 13:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests in the commit queue that are at least two days old and lack a 2nd approval get labeled with
lacks-second-approval. This makes it visible why the pull request has not landed yet and helps collaborators find pull requests that need another review.@node-core/utilschore(main): release 7.2.0 node-core-utils#1162lacks-second-approvallabel innodejs/node-auto-testnodejs/node-auto-testlacks-second-approvallabel innodejs/node