Skip to content

test_runner: print failed coverage reports with dot runner #65628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saitejabandaru-in wants to merge 1 commit into from
+8 −1
Closed

test_runner: print failed coverage reports with dot runner #65628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/internal/test_runner/reporter/dot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,21 @@
yield `${colors.red}X${colors.reset}`;
ArrayPrototypePush(failedTests, data);
}
if ((type === 'test:fail' || type === 'test:pass') && ++count === columns) {
if (type === 'test:diagnostic' && data.level === 'error') {
yield `${colors.red}X${colors.reset}`;
ArrayPrototypePush(failedTests, {
name: data.message,
nesting: data.nesting,
});
}
if ((type === 'test:fail' || type === 'test:pass' || (type === 'test:diagnostic' && data.level === 'error')) && ++count === columns) {
yield '\n';

Check failure on line 30 in lib/internal/test_runner/reporter/dot.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Every object must have __proto__: null
// Getting again in case the terminal was resized.
columns = getLineLength();
count = 0;
}
}

Check failure on line 35 in lib/internal/test_runner/reporter/dot.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

This line has a length of 138. Maximum allowed is 120
yield '\n';
if (failedTests.length > 0) {
yield `\n${colors.red}Failed tests:${colors.white}\n\n`;
Expand Down
Loading