child_process: emit 'close' after explicit disconnect() - #65665
Open
3zrv wants to merge 1 commit into
Open
Conversation
An explicit subprocess.disconnect() closed the IPC channel without counting it towards the subprocess 'close' event, so 'close' was never emitted once the child exited. Route every channel teardown through the same finish() so the accounting happens where the channel is closed, and drop the handle queue on EOF so the disconnect is not postponed forever. Fixes: nodejs#19433 Refs: nodejs#19566 Signed-off-by: Mohamed Sayed <k@3zrv.com>
nodejs-github-bot
added
child_process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit subprocess.disconnect() closed the IPC channel without counting it towards the subprocess 'close' event, so 'close' was never emitted once the child exited. Route every channel teardown through the same finish() so the accounting happens where the channel is closed, and drop the handle queue on EOF so the disconnect is not postponed forever.
Fixes: #19433 #65646
Refs: #19566
After the parent calls
subprocess.disconnect(), the subprocess never emits 'close' once the child exits, even though 'exit' fires and all stdio pipes close. The IPC channel had two teardown paths: the EOF path didmaybeClose(target), but the explicit-disconnect path (_disconnect()→finish()) only closed the channel and emitted 'disconnect', so the channel counted in_closesNeededwas never matched (_closesGotstuck at 2 of 3).This makes finish() the single place a channel is torn down, close the handle and emit 'disconnect', then
maybeClose()and routes the EOF path through it.