sqlite: run backup completion in callback scope - #65666
Open
panva wants to merge 1 commit into
Open
Conversation
panva
added
the
flaky-test
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Run SQLite backup after-work callbacks inside an internal callback scope. This drains promise reactions and next ticks before the event loop can become idle. Add a child-process regression test where backup is the final active request. Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
force-pushed
the
fix-sqlite-backup-microtasks
branch
from
August 30, 2026 12:32
9b71eea to
43d8fdf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65666 +/- ##
==========================================
- Coverage 91.79% 90.05% -1.75%
==========================================
Files 402 754 +352
Lines 181164 255746 +74582
Branches 27776 48325 +20549
==========================================
+ Hits 166308 230317 +64009
- Misses 14517 16541 +2024
- Partials 339 8888 +8549
🚀 New features to boost your workflow:
|
Member
|
Stress tests are skipped on |
trivikr
approved these changes
Aug 30, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run SQLite backup after-work callbacks inside an internal callback scope. This drains promise reactions and next ticks before the event loop can become idle.
Add a child-process regression test where backup is the final active request.
This fixes intermittent
test-sqlite-backuptimeouts observed innodejs/reliabilityand recentnode-test-pull-requestJenkins jobs.