Skip to content

test: deflake WASI poll timing checks - #65672

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-wasi-poll-timeout-flake
Open

test: deflake WASI poll timing checks#65672
panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-wasi-poll-timeout-flake

Conversation

@panva

@panva panva commented Aug 30, 2026

Copy link
Copy Markdown
Member

Use a monotonic high-resolution clock for elapsed-time checks and allow a small tolerance for timer granularity. The previous whole-second clock could report an interval one second short when a slightly early timer coincided with a wall-clock boundary.

@panva panva added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Aug 30, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/wasi

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 30, 2026
Use a monotonic high-resolution clock for elapsed-time checks and allow
a small tolerance for timer granularity. The previous whole-second clock
could report an interval one second short when a slightly early timer
coincided with a wall-clock boundary.

Assisted-by: Codex
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva force-pushed the fix-wasi-poll-timeout-flake branch from 349cac4 to 7c49367 Compare August 30, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants