Skip to content

build: add --shared-abseil configure flag - #65682

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:shared-abseil
Open

build: add --shared-abseil configure flag#65682
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:shared-abseil

Conversation

@aduh95

@aduh95 aduh95 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

A requirement for #65614 (abseil is a requirement of both perfetto and V8, and it needs to be the same version)

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Aug 31, 2026
@github-actions

This comment was marked as outdated.

aduh95 added 2 commits August 31, 2026 18:29
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 485 -> 487 => +2 2 / 487 = 0.4%
aarch64-linux 486 -> 488 => +2 2 / 488 = 0.4%
x86_64-darwin 427 -> 429 => +2 2 / 429 = 0.4%
aarch64-darwin 428 -> 430 => +2 2 / 430 = 0.4%
Total 1826 -> 1834 => +8 8 / 1834 = 0.4%
Changelog
@@ -16,0 +17,8 @@
+/nix/store/zfjmy81j7shdl54pdhqfkxdiqj0k8w6f-abseil-cpp-20260107.1 (aarch64-darwin)
+/nix/store/98crzsncq5khm9cyckslmd2xz8y536va-abseil-cpp-20260107.1 (aarch64-linux)
+/nix/store/g5bfb54qhcprz6fbwy6y0344gyhdq39n-abseil-cpp-20260107.1 (x86_64-darwin)
+/nix/store/vp4ha3gygz1cm6f7qgrrysyyk1nzfgps-abseil-cpp-20260107.1 (x86_64-linux)
+/nix/store/mcbznvdb0xcncmv55gkg8gvyjjasn46k-abseil-cpp-20260107.1-dev (aarch64-darwin)
+/nix/store/wi8nissjz9mxlzk8v8sqa705h5f4qhb6-abseil-cpp-20260107.1-dev (aarch64-linux)
+/nix/store/s84wwacmp88nld1znzjkrn3s0gsg930c-abseil-cpp-20260107.1-dev (x86_64-darwin)
+/nix/store/yf9f11zq3w5da045klvrpvqawh19sz6m-abseil-cpp-20260107.1-dev (x86_64-linux)

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (a844473) to head (5029e74).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65682      +/-   ##
==========================================
- Coverage   90.07%   90.07%   -0.01%     
==========================================
  Files         754      754              
  Lines      256378   256378              
  Branches    48498    48488      -10     
==========================================
- Hits       230936   230921      -15     
  Misses      16572    16572              
- Partials     8870     8885      +15     

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants