test: fix recursive fs.watch error fixture - #65683
Closed
panva wants to merge 1 commit into
Closed
Conversation
Use a child directory so recursive watcher setup always creates a second watch. Linux no longer watches regular files after the directory watcher optimization. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
nodejs-github-bot
added
needs-ci
panva
added
the
fast-track
Contributor
|
Fast-track has been requested by @panva. Please 👍 to approve. |
Collaborator
jasnell
approved these changes
Aug 31, 2026
RafaelGSS
approved these changes
Aug 31, 2026
Member
Author
|
We've got enough passes from CI and fast track approvals to call this a fix. |
panva
added a commit
that referenced
this pull request
Aug 31, 2026
Use a child directory so recursive watcher setup always creates a second watch. Linux no longer watches regular files after the directory watcher optimization. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex PR-URL: #65683 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Member
Author
|
Landed in a844473 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65683 +/- ##
=======================================
Coverage 90.06% 90.07%
=======================================
Files 754 754
Lines 256360 256369 +9
Branches 48486 48494 +8
=======================================
+ Hits 230891 230913 +22
- Misses 16584 16597 +13
+ Partials 8885 8859 -26 🚀 New features to boost your workflow:
|
Member
Author
|
https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix72-power9/64916/ appears to be a separate failure specific to AIX, i have no time to look into it now, @aduh95 @jasnell can you maybe take a look? or someone else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test introduced in #65635 was invalidated by #65486, both landed independently. This fixes a consistent test failure on main.