Skip to content

src: fix startup snapshot reproducibility of InternalFieldInfo #65684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
legendecas wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

src: fix startup snapshot reproducibility of InternalFieldInfo #65684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/node_snapshotable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,11 @@ struct InternalFieldInfoBase {
template <std::derived_from<InternalFieldInfoBase> T>
static T* New(EmbedderObjectType type) {
void* buf = ::operator new[](sizeof(T));
memset(buf, 0, sizeof(T)); // Make the padding reproducible.
T* result = new (buf) T;
// Zero the padding to make the bytes handed to V8 reproducible. Must come
// after the placement new, or -flifetime-dse drops it as a dead store.
// https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html#index-fno-lifetime-dse
memset(static_cast<void*>(result), 0, sizeof(T));
result->type = type;
result->length = sizeof(T);
return result;
Expand Down
Loading