v8,lib: remove runtime gating of Float16array - #65702
Open
aduh95 wants to merge 5 commits into
Open
Conversation
Original commit message:
[cleanup] Remove --js-float16array
Remove the --js-float16array flag and incorporate Float16Array into the
standard typed array macros and baseline snapshot unconditionally.
Float16Array has been shipping by default since M138.
Bug: 548385945
TAG=agy
CONV=052f499d-4ee5-4a10-8afd-900ba4a338db
Change-Id: I2c0012158febf422fdc1b866b9414f3f040e83ad
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8264275
Reviewed-by: Nikolaos Papaspyrou <nikolaos@chromium.org>
Auto-Submit: Olivier Flückiger <olivf@chromium.org>
Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109335}
Refs: v8/v8@f3d4d45
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
added
dont-land-on-v22.x
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
marco-ippolito
approved these changes
Sep 1, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65702 +/- ##
==========================================
- Coverage 90.06% 90.06% -0.01%
==========================================
Files 754 754
Lines 256395 256395
Branches 48500 48498 -2
==========================================
- Hits 230922 230910 -12
- Misses 16574 16613 +39
+ Partials 8899 8872 -27
🚀 New features to boost your workflow:
|
panva
approved these changes
Sep 1, 2026
juanarbol
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime flag was removed upstream in v8/v8@f3d4d45, let's land this before Node.js 26 is LTS