Skip to content

fix: honor SOCKS5 connection timeout - #5733

Open
mcollina wants to merge 1 commit into
mainfrom
fix/socks5-connect-timeout
Open

fix: honor SOCKS5 connection timeout#5733
mcollina wants to merge 1 commit into
mainfrom
fix/socks5-connect-timeout

Conversation

@mcollina

Copy link
Copy Markdown
Member

Honor connectTimeout across SOCKS5 proxy setup, authentication, CONNECT negotiation, and target TLS upgrades. Forward the option through ProxyAgent, surface standard connect timeout errors, and add focused regression coverage plus synchronized documentation and types.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.90110% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.48%. Comparing base (fc3450d) to head (d1fa1d8).

Files with missing lines Patch % Lines
lib/dispatcher/socks5-proxy-agent.js 98.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5733      +/-   ##
==========================================
+ Coverage   93.47%   93.48%   +0.01%     
==========================================
  Files         110      110              
  Lines       38908    38977      +69     
==========================================
+ Hits        36368    36439      +71     
+ Misses       2540     2538       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants