fix: normalize object prototype in proxy-agent test - #5734
Closed
spjoshis wants to merge 2 commits into
Closed
Conversation
fix: normalize object prototype in proxy-agent test What Problem This Solves: nightly test fails due to prototype mismatch in deepStrictEqual comparison Why This Change Was Made: Object.create(null) and plain object literals have different prototypes, causing strict equality to fail even when structure is identical User Impact: Fixes failing nightly test suite Evidence: test/proxy-agent.js now passes
spjoshis
changed the title
|
This PR changes 0 files and cannot have any effect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes nightly test failure in proxy-agent.js:1015 caused by prototype mismatch in deepStrictEqual comparison.
What Problem This Solves
The test was failing because expectedHeaders was created with Object.create(null) (resulting in an object with null prototype) while req.headers (from Node.js HTTP handler) is a plain object. deepStrictEqual fails when comparing objects with different prototypes, even if their contents are identical.
Why This Change Was Made
Object.create(null) creates an object with null prototype, while plain object literals have Object.prototype. This difference causes strict equality checks to fail even when the actual property values are the same.
User Impact
Fixes the failing nightly test suite in test/proxy-agent.js.
Evidence
test/proxy-agent.js now passes all 38 tests.
Fixes #5671