Add chunked upload support to legacy SWORD routes

[ShanaLMoore]

Summary

Extends the chunked upload feature (V2) to also work on the legacy SWORD routes. The protocol is identical — In-Progress: true to initiate staging, PUT with Content-Range to send chunks, In-Progress: false to finalize — only the URLs differ.

Step	V2 route	Legacy route
Initiate staging	POST /sword/v2/works/{WID}/file_sets	POST /sword/collections/{CID}/works/{WID}/file_sets
Send chunks	PUT /sword/v2/file_sets/{STAGING_ID}	PUT /sword/collections/{CID}/works/{WID}/file_sets/{STAGING_ID}
Check status	GET /sword/v2/file_sets/{STAGING_ID}	GET /sword/collections/{CID}/works/{WID}/file_sets/{STAGING_ID}

Non-chunked POST/PUT behavior for works and file sets is unchanged on both legacy and V2.

What changed

1. WillowSword::SwordError — new StandardError subclass wrapping WillowSword::Error. Required by ChunkedUploadHandler (was referenced but never defined). Also added missing error types: :chunk_sequence_error (416), :upload_not_found (404), :upload_incomplete (409).

2. Shared staging status view — moved staging_status.xml.builder from v2/file_sets/ to shared/ so both legacy and V2 controllers render the same SWORD staging XML.

3. collection_id in staging manifest — legacy routes are nested under /collections/{CID}/works/{WID}/, so the collection ID is stored in the manifest alongside work_id for use in response URL generation. The new collection_id: keyword arg defaults to nil, so V2 callers are unaffected.

4. Legacy FileSetsController — includes ChunkedUploadHandler and adds chunking support to create, show, and update. The V2 controller inherits this include so the redundant include there is removed. Uses rescue_from SwordError (narrowly scoped) rather than the V2 HandleError concern to avoid changing existing legacy error handling. Renders legacy Atom feed XML on finalization, not HykuCrosswalk.

5. with_manifest_lock fix — when append_chunk is called with a nonexistent upload ID, the staging directory doesn't exist, so File.open on the .lock file raised Errno::ENOENT. Now checks directory existence first and raises the expected SwordError(:upload_not_found).

The V2 controller completely overrides create/show/update, so base controller changes do not affect V2 behavior.

Kirk's review shortcut

12 of the 17 files are unchanged from your PR #59 review. The new work is 5 files:

• app/controllers/willow_sword/file_sets_controller.rb — legacy chunking support (main change)
• app/views/willow_sword/shared/staging_status.xml.builder — moved from v2/file_sets/, same content
• app/controllers/concerns/willow_sword/chunked_upload_handler.rb — 2 small additions: collection_id: param + directory check in with_manifest_lock
• lib/willow_sword/sword_error.rb — new 12-line file
• spec/request/legacy/chunked_deposit_spec.rb — new legacy integration test

Ticket Number

• palni_palci_knapsack#617

Test Results

Tested all four scenarios on pittir-staging.hykucommons.org (2026-05-05):

#	Test	Route	HTTP Codes	Result
1	Non-chunked file set upload	V2	201 (work), 201 (file set)	PASS
2	Chunked file set upload (2 chunks)	V2	201 (staging), 200 (chunk), 201 (finalize)	PASS
3	Non-chunked file set upload	Legacy	201 (work), 201 (file set)	PASS
4	Chunked file set upload (2 chunks)	Legacy	201 (staging), 200 (status), 200 (chunk), 201 (finalize)	PASS

Expected Behavior

• Default deposits unchanged: single POST to create a work or attach a file set, without In-Progress/Content-Range headers, behaves exactly as before on both legacy and V2.
• Chunked file set uploads (legacy): same protocol as V2 — POST with In-Progress: true to initiate staging, PUT with Content-Range to send chunks, final PUT with In-Progress: false to finalize. Legacy URLs are nested (/collections/{CID}/works/{WID}/file_sets/{STAGING_ID}), and finalization renders the legacy Atom feed XML format.
• Staging: shared tmp/network_files/... works across pods; flock on .lock does not error on EFS/NFS.
• Cleanup: CleanupStaleUploadsJob and the rake task work the same as before.