docs: say which of the three Nhimbe repos this is, and drop links to untracked files - #134
Merged
Merged
Conversation
…untracked files Nhimbe, mukoko-events-admin and mukoko-events-mcp are three repos for one product, and none of the three READMEs said which piece it was. Added a table: this repo is the public app AND the data plane — the Next.js app, the MongoDB layer, the /api/events* REST surface and the .well-known documents the MCP's OAuth challenge points clients at. The admin app and the MCP server are named with their own domains. Noted what this repo does NOT contain: no src/app/admin (it 307s to admin.events.mukoko.com) and no wrangler.toml. Broken links removed. The README linked ./CLAUDE.md three times and ./.claude/skills/ once. Commit 5ce74ca untracked both, so all four links 404 on a fresh clone — including the sentence sending readers to CLAUDE.md for the environment-variable list, which actually lives in .env.example. Repointed at .env.example, AGENTS.md and docs/, and said plainly that CLAUDE.md and .claude/ are untracked local conveniences. The dual-domain fact was missing entirely. Both events.mukoko.com and nhimbe.com serve the app; events.mukoko.com is the canonical primary that every self-referential URL points at (src/lib/site-url.ts). The README named only nhimbe.com. Live badge and header now lead with the primary and list both. Removed two committed model identifiers from the stack section — AGENTS.md forbids putting them in code, commits or docs, and the README was breaking its own repo's rule. Dropped the hardcoded "~682 tests" count, which drifts on every commit, and added the integration-test script the Quickstart omitted. Added the CI badge (curled: 200 — this repo is public). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nhimbe, mukoko-events-admin and mukoko-events-mcp are three repos for one
product, and none of the three READMEs said which piece it was. Added a table:
this repo is the public app AND the data plane — the Next.js app, the MongoDB
layer, the /api/events* REST surface and the .well-known documents the MCP's
OAuth challenge points clients at. The admin app and the MCP server are named
with their own domains. Noted what this repo does NOT contain: no src/app/admin
(it 307s to admin.events.mukoko.com) and no wrangler.toml.
Broken links removed. The README linked ./CLAUDE.md three times and
./.claude/skills/ once. Commit 5ce74ca untracked both, so all four links 404 on
a fresh clone — including the sentence sending readers to CLAUDE.md for the
environment-variable list, which actually lives in .env.example. Repointed at
.env.example, AGENTS.md and docs/, and said plainly that CLAUDE.md and .claude/
are untracked local conveniences.
The dual-domain fact was missing entirely. Both events.mukoko.com and
nhimbe.com serve the app; events.mukoko.com is the canonical primary that every
self-referential URL points at (src/lib/site-url.ts). The README named only
nhimbe.com. Live badge and header now lead with the primary and list both.
Removed two committed model identifiers from the stack section — AGENTS.md
forbids putting them in code, commits or docs, and the README was breaking its
own repo's rule.
Dropped the hardcoded "~682 tests" count, which drifts on every commit, and
added the integration-test script the Quickstart omitted. Added the CI badge
(curled: 200 — this repo is public).
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com