fix: stop tracking .env and ship .env.example instead - #539
Open
softwarebyze wants to merge 1 commit into
Open
Conversation
The template currently commits .env (including SECRET_KEY=my-secret-key). create-obytes-app copies that into every new app, so a real token typed into .env is one git add away from being pushed. Keep the same keys in .env.example, gitignore .env / .env*.local, and document the copy step.
✅ Deploy Preview for obytes-starter ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The template tracks
.envonmaster:https://github.com/obytes/react-native-template-obytes/blob/master/.env
create-obytes-appclones this repo, so every new app starts with a committed.env. The docs already tell people to put build-time secrets in.envwithoutEXPO_PUBLIC_— which is correct for Metro, but dangerous while.envis tracked. A real token is onegit add .away from GitHub..p8/.key/.p12are already gitignored..envis not.Fix
.env→.env.example(same keys, dummy values).envand.env*.local.env.example→.envlocally; do not commit.envEvidence
On
mastertoday, that file is part of the tree. After this PR,git ls-files .envis empty and new clones only get.env.example.