Add click, pointer over, and pointer out event handling to GeoLine and GeoPolygon - #120
Open
nickw1 wants to merge 1 commit into
Open
Add click, pointer over, and pointer out event handling to GeoLine and GeoPolygon#120nickw1 wants to merge 1 commit into
nickw1 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows
GeoLineandGeoPolygonelements to be clickable and handlepointeroverandpointeroutevents.Added
onClick,onPointerOverandonPointerOutattributes to the above components. These are forwarded to the appropriate mesh or group.NOTE that I had to set the Biome accessibility rule
noStaticElementInteractionstowarnto allow the commit to be accepted. Biome was giving an error due to adding event handlers to non-input elements. I realise this is a bit quick and dirty, but the rule is presumably aimed more at HTML elements. @coopbri not sure what you want to do about this?Test Steps
Geolocation test app shows examples of
onClickhandlers on the twoGeoLines and theGeoPolygon. Tested the app on a desktop machine - confirmed as working.