Skip to content

Add support for passing categoricals to Glm as-is #30

Description

@jwdink

It would not be very difficult to update Glm to handle categorical columns natively: i.e. run them through LabelEncoder then pass that to a torch.nn.Embedding layer instead of torch.nn.Linear.

This would improve performance immensely for high-cardinality categorical features (esp. since sparse-matmul seems to be pretty slow).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions