Make Qwen4Exp download diagnostics truthful - #698
Draft
justinchuby wants to merge 3 commits into
Draft
Conversation
Performance Comparison
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines Qwen4Exp GGUF “fail-closed” diagnostics so they accurately distinguish between (a) bounded-header preflight that does not require downloading the full GGUF payload and (b) fallback paths that may download an immutable file/shard set for local validation before rejecting.
Changes:
- Extend the Qwen4Exp rejection helper to optionally encode whether a Hub payload was downloaded, and adjust messaging to avoid unconditional “no download” claims.
- Thread the new
payload_downloaded=Falsesignal through GGUF Hub preflight rejection call sites. - Update docs and add a regression test to ensure fallback downloads don’t produce “no download” messaging.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/mobius/integrations/gguf/_qwen4_exp.py | Adds payload_downloaded context to fail-closed error construction and updates diagnostic wording. |
| src/mobius/integrations/gguf/_builder.py | Passes payload_downloaded=False for bounded-header preflight Qwen4Exp rejection points. |
| src/mobius/integrations/gguf/_qwen4_exp_test.py | Updates expectations and adds a regression covering fallback-download-before-rejection messaging. |
| docs/design/qwen4-exp-text-core.md | Documents bounded-header preflight vs fallback full-download validation behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
justinchuby
marked this pull request as draft
August 28, 2026 23:59
10 tasks
Distinguish bounded-header preflight rejection, where Mobius can guarantee no GGUF payload download, from local validation after the intentional immutable-download fallback. Keep tensor conversion fail-closed and document the fallback accurately. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7f812ed6-7e89-4065-880e-3b88c39d98cc Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Describe successful Qwen4Exp preflight in terms of bounded range data and complete file or shard downloads, since the range can include initial tensor bytes. Cover small-header range responses and split-set fallback with mocked regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7f812ed6-7e89-4065-880e-3b88c39d98cc Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Use Hub file size and received range length to distinguish partial preflight data from a complete small GGUF response. Propagate the tri-state through renamed split discovery so Qwen4Exp rejection diagnostics remain truthful for every bounded-header path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7f812ed6-7e89-4065-880e-3b88c39d98cc Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
force-pushed
the
justinchuby-fix-qwen4exp-download-claim
branch
from
August 30, 2026 15:15
79183fc to
3e7c168
Compare
justinchuby
added a commit
that referenced
this pull request
Aug 31, 2026
## Summary - pin all JSON evidence under `testdata/evidence/`, including nested paths, to `text eol=lf` - refresh both hash-bound traces with semantics-preserving leading JSON whitespace so existing Windows worktrees receive new LF-normalized blobs - preserve future non-JSON evidence as unclassified so binary artifacts are not treated as text - validate effective attributes in an isolated temporary Git repository with system/global/caller-repository attribute sources excluded - regress metadata-bound LF bytes, simulated CRLF bytes, and canonical parsed-JSON semantics ## Validation - draft evidence unit and integration guards: 4 passed, 2 skipped (opt-in real 16 GiB probes disabled) - evidence/artifact suite: 85 passed - `lintrunner f --output oneline --all-files` - `git diff --check` - exact-head GPT-5.6 Sol review: no significant issues ## Evidence identities - dflash blob: `bf42e00a181fa54a2fe6da19ae85c0c810b8c58f` -> `b2966dd06ae6daa5f5b764ebd8d12b74f8824d69` - dflash LF: `1062e5ed665aeafbcf0d0fb250f9b48c520091ebc4b2ad6b19dbd341518c481f`; simulated CRLF: `e0e70e909f33ed44aa87da39bab721ebbee0c3e730e2f89dbc509c6683701e42` - eagle3 blob: `9498c417c8a22cf1a387b7dbd801a8701df0cfae` -> `9e02745b6f3b087dbdce4d5fc9d7ff224af0ba6b` - eagle3 LF: `9d6c6fdb630bc0a040eacc2a2357a2991609ea0d904ff16574a9b55f7d010d55`; simulated CRLF: `78aa94f24d5f1b9ae020de1ffa5a70c6a30f30ff45eb5310a540cdd2b3d8fab2` ## Follow-up PR #698 must rebase this fix from `main` before its Windows jobs can pass. --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
python -m pytest src/mobius/integrations/gguf/_qwen4_exp_test.py -q --tb=short— 14 passedlintrunner --output oneline --all-filesgit diff --checkBase:
dcf8bab5d7f1e1afb2d220ed0b30d8ee8c075b1fHead:
6edd2d3c1eb4a4d116fd6a588850e3d1f3b8ca47Follow-up to merged #676 and its suppressed Copilot review finding.