Skip to content

feat(doctor): X6 (part) — dns /etc/hosts probe #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavobertoi merged 1 commit into from
Jun 29, 2026
Merged

feat(doctor): X6 (part) — dns /etc/hosts probe #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions internal/cli/doctor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ import (

"github.com/spf13/cobra"

"github.com/open-source-cloud/devstack/internal/config"
"github.com/open-source-cloud/devstack/internal/dns"
"github.com/open-source-cloud/devstack/internal/docker"
"github.com/open-source-cloud/devstack/internal/proxy"
"github.com/open-source-cloud/devstack/internal/state"
"github.com/open-source-cloud/devstack/internal/trust"
"github.com/open-source-cloud/devstack/internal/xdg"
Expand Down Expand Up @@ -135,6 +138,26 @@ func runDoctor(cmd *cobra.Command) []docker.Check {
checks = append(checks, docker.Check{Name: "state ledger", Status: docker.StatusOK, Detail: fmt.Sprintf("schema v%d @ %s", v, ctxName)})
}

// DNS entries for *.localhost (spec 05) — best-effort, only when the current
// dir is a workspace with a configured proxy. Never fatal (opt-in).
if m, err := config.Load(cwd); err == nil && proxy.Enabled(m) {
var hosts []string
for _, r := range proxy.BuildRoutes(m) {
hosts = append(hosts, r.Host)
}
if missing, err := dns.Missing(dns.DefaultHostsPath, hosts); err == nil {
if len(missing) == 0 {
checks = append(checks, docker.Check{Name: "dns (/etc/hosts)", Status: docker.StatusOK, Detail: fmt.Sprintf("%d *.localhost host(s) resolved", len(hosts))})
} else {
checks = append(checks, docker.Check{
Name: "dns (/etc/hosts)", Status: docker.StatusWarn,
Detail: fmt.Sprintf("%d of %d *.localhost host(s) missing", len(missing), len(hosts)),
Remediation: "run `sudo devstack dns setup`",
})
}
}
}

// Local-CA trust (spec 05) — opt-in, so never fatal: report readiness as a
// warning with the exact remediation when not fully set up.
ts := trust.New().Status(ctx)
Expand Down
Loading