feat(orchestrate): X3 — workspace + project preUp/postUp hooks in the saga - #46
Merged
Conversation
…into the saga (spec 11) Generalize hooksPhase → hookPhase (any scope + phase) and wire the full hook ordering into `up`: workspace preUp → per-project (preUp → compose-up → postUp) → workspace postUp. Workspace-scope hooks run from the workspace root (no compose project); project hooks from the repo root with the project's compose coords. All reuse the C4 runner (timeout/retries/onFailure, ledger+flock). --no-hooks skips them all. (firstRun/postPull — the idempotent, ledger-keyed hooks — still wait on the provision phase for their data-volume scope_key; preUp/postUp are unconditional and land now.) Tests: hook ordering (ws-preUp < app-preUp < compose-up), and the happy path now covers postUp@app; re-run treats preUp/postUp as AlwaysRun. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalizes
hooksPhase→hookPhaseand wires the full spec-11 ordering intoup: workspace preUp → per-project (preUp → compose-up → postUp) → workspace postUp. Workspace hooks run from the workspace root; project hooks from the repo root with the project's compose coords. Reuses the C4 runner;--no-hooksskips all. (firstRun/postPull still wait on the provision phase for their scope_key.) Tests: ordering (ws-preUp < app-preUp < compose-up) + happy-path postUp.make cigreen.🤖 Generated with Claude Code