feat(orchestrate): N5 — fenced trust phase in the up saga - #51
Merged
Conversation
Add the spec-09 phase-7 trust step: when network.proxy.httpsLocal is set, the up saga installs the local CA (trust.Install / mkcert -install). It is FENCED — a missing mkcert or no sudo degrades to a warning detail and NEVER aborts `up` (local HTTPS is opt-in). A no-op when httpsLocal is off. Trust is injectable (UpDeps.Trust) for tests. With the proxy-label generate wiring (PR #29) and the doctor trust/dns probes, this completes the M5 saga integration (N5). Test: httpsLocal on + a failing mkcert → phase returns ok with status=warning (fenced); httpsLocal off → skipped. Re-run treats `trust` as AlwaysRun. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the spec-09 phase-7 trust step: when
network.proxy.httpsLocal, the saga installs the local CA (mkcert). Fenced — missing mkcert/no sudo → warning, never abortsup; no-op when off. Trust injectable for tests. Completes M5 saga integration (with proxy labels #29 + doctor probes). Test: failing install → fenced warning; off → skipped.make cigreen.🤖 Generated with Claude Code