feat(secrets): S4 — Infisical provider via the infisical CLI — M4 COMPLETE - #67
Merged
Conversation
…) — M4 secrets COMPLETE
Adds the `infisical` provider kind, mirroring S2/S3: shells to the `infisical`
CLI (not the Go SDK — anti-bloat, DECISIONS) and inherits the user's auth
(`infisical login` / INFISICAL_TOKEN), so no credential passes through devstack.
The environment is exported ONCE (`infisical export --format=json`, batched) with
optional --projectId/--env/--path, then each ref's key is extracted; a #key walks
a JSON-valued secret.
Export-format drift across Infisical versions is handled by tolerant parsing:
accepts both a flat {KEY:VALUE} object and a list of {key/secretKey,
value/secretValue} records. Fake-runner tested for both shapes + JSON #key +
missing-secret + missing-CLI + builtin registration.
Account-gated (decision #3): logic + fakes here; the exact CLI version/contract is
a flagged owner-verify step, not run in the nightly. Stdlib-only (no new deps).
This completes M4: S1 (core) · S2 (SOPS+age) · S3 (AWS SM/SSM) · S4 (Infisical) ·
S5 (keyring login) · S6 (post-render inject + leak test).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
infisicalprovider kind. Completes M4 secrets (S1–S6 all in).How
Mirrors S2/S3: shells to the
infisicalCLI (not the Go SDK — anti-bloat, DECISIONS) and inherits the user's auth (infisical login/INFISICAL_TOKEN). Exports the environment once (infisical export --format=json, batched) with optional--projectId/--env/--path; extracts each ref's key;#keywalks a JSON-valued secret.Version-drift tolerance:
parseInfisicalExportaccepts both shapes the CLI has emitted — a flat{KEY:VALUE}object and a list of{key/secretKey, value/secretValue}records.Tests
Fake-runner: flat-object format (+ projectId/env args), list format + JSON
#key, missing-secret error, missing-CLI error, builtin registration. Stdlib-only (no new deps).make cigreen.Scope (decision #3)
Account-gated: logic + fakes here; the exact CLI version/contract is a flagged owner-verify step, not run in the nightly. Tolerant parsing covers the two documented shapes so a real account should "just work"; if a future version changes the format, only
parseInfisicalExportneeds a tweak.🤖 Generated with Claude Code