refactor: resolve the account settings link with frontend-base - #135
Merged
arbrandes merged 1 commit intoSep 22, 2026
Merged
Conversation
The settings icon checked whether the account route was a path in this site or an external URL by hand; frontend-base now owns that. Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
commented
Sep 22, 2026
Contributor
Author
There was a problem hiding this comment.
Claude reviewed and found no defects: ready to merge.
isInternal agrees with the old scheme regex for every URL the config can produce, and correctly rejects protocol-relative URLs the regex let through. generatePath is a no-op on the param-less account path, so the resulting URL is unchanged. The site config restore in the tests is sound, since mergeSiteConfig never mutates the previous config; the { ...getSiteConfig() } spread is redundant but harmless.
Full suite, lint, and tsc --noEmit pass locally against alpha.15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The settings icon in the notification tray tested the account route against a scheme regex to choose between a react-router
Linkand a ParagonHyperlinkthat opens a new tab. It now takes that answer from frontend-base'sresolveRouteByRole. Tests cover both cases against the test site config.Follow-up to openedx/frontend-base#317. frontend-base is bumped to 2.0.0-alpha.15, which provides it.
LLM usage notice
Built with assistance from Claude.